Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update check when no update is available #17804

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Fix update check when no update is available #17804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c89f9a5
fix #17800 recression of #17310
christopherpross Mar 8, 2025
ef4ac2c
Update source/updateCheck.py
SaschaCowley Mar 11, 2025
313c99b
Update changes
SaschaCowley Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/updateCheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@ def checkForUpdate(auto: bool = False) -> UpdateInfo | None:
raise RuntimeError(f"Checking for update failed with HTTP status code {res.code}.")

data = res.read().decode("utf-8") # Ensure the response is decoded correctly
# if data is empty, we return None, because the server returns an empty response if there is no update.
if not data:
return None
try:
parsed_response = UpdateInfo.parseUpdateCheckResponse(data)
except ValueError:
Expand Down
2 changes: 1 addition & 1 deletion user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ To use this feature, "allow NVDA to control the volume of other applications" mu
* NVDA can now report when a link destination points to the current page. (#141, @LeonarddeR, @nvdaes)
* Added an action in the Add-on Store to cancel the install of add-ons. (#15578, @hwf1324)
* Added an action in the Add-on Store to retry the installation if the download/installation of an add-on fails. (#17090, @hwf1324)
* It is now possible to specify mirror URLs to use for NVDA updates and the Add-on Store. (#14974, #17151, #17310, @christopherpross)
* It is now possible to specify mirror URLs to use for NVDA updates and the Add-on Store. (#14974, #17151, #17310, #17804, @christopherpross)
* The add-ons lists in the Add-on Store can be sorted by columns, including publication date, in ascending and descending order. (#15277, #16681, @nvdaes)
* When decreasing or increasing the font size in LibreOffice Writer using the corresponding keyboard shortcuts, NVDA announces the new font size. (#6915, @michaelweghorn)
* When applying the "Body Text" or a heading paragraph style using the corresponding keyboard shortcut in LibreOffice Writer 25.2 or newer, NVDA announces the new paragraph style. (#6915, @michaelweghorn)
Expand Down