WIP: allow popups to be resized
#15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds table to keep track of `Border`s associated to `popup`s - adds function to resize a `popup` - relies on nvim-lua/plenary.nvim#180
- add relative key to `win_opts` which is set to 'editor' - small renaming and typos
l-kershaw
added a commit
to l-kershaw/telescope.nvim
that referenced
this pull request
Jul 5, 2021
- implements `Picker:recalculate_layout` function - adds an autocommand to call this function on the `VimResized` event - relies on nvim-lua/plenary.nvim#180 and nvim-lua/popup.nvim#15 Currently has issues when the results window increases in height
|
Do you need anything from me here? I am trying to catch up on (very delayed) reviews in popup and plenary. |
|
I honestly can't remember where I was up to on this and the related PRs in |
|
Closing in favour of plenary PR as popup functionality has moved to plenary |
l-kershaw
added a commit
to l-kershaw/telescope.nvim
that referenced
this pull request
Oct 10, 2021
- implements `Picker:recalculate_layout` function - adds an autocommand to call this function on the `VimResized` event - relies on nvim-lua/plenary.nvim#180 and nvim-lua/popup.nvim#15 Currently has issues when the results window increases in height
l-kershaw
added a commit
to l-kershaw/telescope.nvim
that referenced
this pull request
Oct 18, 2021
- implements `Picker:recalculate_layout` function - adds an autocommand to call this function on the `VimResized` event - relies on nvim-lua/plenary.nvim#180 and nvim-lua/popup.nvim#15 Currently has issues when the results window increases in height lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borders associated topopupspopupBorders andpopups to be resized plenary.nvim#180Initial commit is a first attempt and probably needs looking through closely to make sure I haven't missed anything.