refactor(deprecations): type annotations using table proxying#1964
Open
pynappo wants to merge 8 commits into
Open
refactor(deprecations): type annotations using table proxying#1964pynappo wants to merge 8 commits into
pynappo wants to merge 8 commits into
Conversation
fa6fdc6 to
f7c6f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a util that creates a new table that "proxies" the original one w/ metatable magic (basically the proxy table is a tree where each node contains the full list of keys to access it, and tree nodes are generated on-demand)
This way we can do some type casting and be able to more easily migrate things like:
Not sure about performance but DX should be way better than typing in dot-delimited string index paths into raw strings with no typing hints