Skip to content

feat(adaptive_size): floating window's optional adaptive size specification #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MrFixThis
Copy link
Contributor

Given the last merged PR (#1556) suggested by @Khrees, the floating window's adaptive size has been fully blocked, making impossible to allow it for those who actually use it.

if M.View.float.enable and not M.View.adaptive_size then
  -- if the floating windows's adaptive size is not desired, then the
  -- float size should be defined in view.float.open_win_config
  return
end

So i propose to check both the floating window and adaptive size configuration to avoid the resizing behavior in floating windows only when the adaptive size is disabled.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK with a variety of open_win_config and float false.

@alex-courtis
Copy link
Member

Please review @Khrees

@Khrees
Copy link
Contributor

Khrees commented Aug 29, 2022

Looks good to me.

@alex-courtis alex-courtis merged commit 757951b into nvim-tree:master Aug 29, 2022
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants