Fall back to .node-version if it exists#3351
Draft
mcaskill wants to merge 3 commits intonvm-sh:masterfrom
Draft
Conversation
mcaskill
force-pushed
the
feature/node-version
branch
from
d25505a to
bf89c7c
Compare
ljharb
requested changes
May 14, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Same comment as on the other PR: Per #794 (comment), I still think this feature should be blocked on nodejs/version-management#13
|
I would really like to see this implemented. It appears that the discussion around establishing a standard is not likely to conclude soon. |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
c6cfc3a to
c20db2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1625 which was abandoned.
Resolves #794.
I rebased the latest changes of the
masterbranch and fixed an issue with the changes made tonvm_find_up().