Changed setting the architecture for Alpine to also work for arm64#3628
Changed setting the architecture for Alpine to also work for arm64#3628malice00 wants to merge 1 commit intonvm-sh:masterfrom
Conversation
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
|
Are you saying that there's no publicly available node distribution for this use case? |
|
Only the x64 version on node's unofficial-project. Project: https://github.com/nodejs/unofficial-builds |
|
So, we decided to make our builds publicly available. Still not sure on how to add a test, but local testing works with this URL: https://raw.githubusercontent.com/appthreat/nodejs-unofficial-builds/master/dists/. Currently it only contains |
|
Could you just name it "x64" on your custom mirror, and install it that way, without any changes to nvm? |
|
Unfortunately, no, because we also use the actual x64 from there. |
|
ok - i'm willing to accept this if there's added unit tests for |
|
I'll see what I can do |
This fixes #3616 by not having the architecture hardcoded to
x64-musl, but instead appending the-muslpart to the architecture that was already found.I am unable to supply tests, since the tarball I want to have loaded only exists on a private server. But the existing alpine-test should still work -- couldn't test this because the test would generally not run on my machine, probably because I am generally using nvm.