Skip to content

Installer: display info about shell config file if unable to write to it. #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MaddyGuthridge wants to merge 4 commits into
base: master
Choose a base branch
from
+47 −2
Draft

Installer: display info about shell config file if unable to write to it. #3789

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b990917
Installer: display info about shell config file if unable to write to
MaddyGuthridge Feb 20, 2026
ee9eed5
install.sh nvm_profile_info: Ensure REAL_PROFILE variable always has a
MaddyGuthridge Feb 20, 2026
ebe55af
Fix shellcheck
MaddyGuthridge Feb 20, 2026
219adf6
Remove accidentally duplicated comment
MaddyGuthridge Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,38 @@ nvm_check_global_modules() {
fi
}

nvm_profile_info() {
local NVM_PROFILE
local PROFILE_PERMISSIONS
local PROFILE_OWNER
local REAL_PROFILE

NVM_PROFILE=$1
# readlink should be available on Linux, BSDs and macOS
REAL_PROFILE=$(readlink "$NVM_PROFILE")
# If output is empty, then it wasn't a symlink
if [ -z "$REAL_PROFILE" ]; then
REAL_PROFILE="$NVM_PROFILE"
fi
# Get info about profile:
# Tools that specifically get this info are not cross-platform, so we rely on
# `ls`, which has consistent output on POSIX systems.
# https://unix.stackexchange.com/a/7733/161355
# shellcheck disable=SC2012
PROFILE_PERMISSIONS="$(ls -ld "$REAL_PROFILE" | awk 'NR==1 {print $1}')"
# shellcheck disable=SC2012
PROFILE_OWNER="$(ls -ld "$REAL_PROFILE" | awk 'NR==1 {print $3}')"

nvm_echo "=> Info about $NVM_PROFILE:"
if [ "$NVM_PROFILE" != "$REAL_PROFILE" ]; then
nvm_echo " Real path of $NVM_PROFILE: $REAL_PROFILE"
fi
nvm_echo " Owner: $PROFILE_OWNER (you are $(whoami))"
nvm_echo " Permissions: $PROFILE_PERMISSIONS"
nvm_echo "=> You may need to modify the file owner or permissions to grant $(whoami)"
nvm_echo " write access."
}

nvm_do_install() {
if [ -n "${NVM_DIR-}" ] && ! [ -d "${NVM_DIR}" ]; then
if [ -e "${NVM_DIR}" ]; then
Expand Down Expand Up @@ -448,14 +480,27 @@ nvm_do_install() {
fi
if ! command grep -qc '/nvm.sh' "$NVM_PROFILE"; then
nvm_echo "=> Appending nvm source string to $NVM_PROFILE"
command printf "${SOURCE_STR}" >> "$NVM_PROFILE"
command printf "${SOURCE_STR}" >> "$NVM_PROFILE" || {
nvm_echo "=> Failed to add nvm source string to $NVM_PROFILE"
nvm_profile_info "$NVM_PROFILE"
nvm_echo "=> Or, you can the following lines to the file yourself:"
command printf "${SOURCE_STR}"
nvm_echo
}
else
nvm_echo "=> nvm source string already in ${NVM_PROFILE}"
fi
# shellcheck disable=SC2016
if ${BASH_OR_ZSH} && ! command grep -qc '$NVM_DIR/bash_completion' "$NVM_PROFILE"; then
nvm_echo "=> Appending bash_completion source string to $NVM_PROFILE"
command printf "$COMPLETION_STR" >> "$NVM_PROFILE"
command printf "$COMPLETION_STR" >> "$NVM_PROFILE" || {
nvm_echo "=> Failed to add nvm source string to $NVM_PROFILE"
nvm_profile_info "$NVM_PROFILE"
nvm_echo "=> Or, you can the following lines to the file yourself:"
nvm_echo
command printf "${COMPLETION_STR}"
nvm_echo
}
else
nvm_echo "=> bash_completion source string already in ${NVM_PROFILE}"
fi
Expand Down
Loading