Add azure support

controllers/node_controller.go

@@ -26,6 +26,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/tools/record"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/manager"
 
 	corev1 "k8s.io/api/core/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -56,26 +57,43 @@ const (
 	providerNodeStatusNotFound
 )
 
-var (
-	errProviderIDEmpty = errors.New("ProviderID is empty")
-)
+// nodeReconciler reconciles a Node object
+type nodeReconciler struct {
+	cloud          cloudprovider.Interface
+	client         client.Client
+	recorder       record.EventRecorder
+	cloudInstances cloudprovider.Instances
+	log            logr.Logger
+	scheme         *runtime.Scheme
+	dryRun         bool
+}
+
+// RegisterNodeReconciler creates and registers the node reconciler.
+func RegisterNodeReconciler(mgr manager.Manager, cloud cloudprovider.Interface, dryRun bool) error {
+	instances, success := cloud.Instances()
+	if !success {
+		return errors.New("unable to set up cloud instances provider")
+	}
+
+	r := &nodeReconciler{
+		cloud:          cloud,
+		recorder:       mgr.GetEventRecorderFor("cloud-lifecycle-controller"),
+		client:         mgr.GetClient(),
+		cloudInstances: instances,
+		log:            ctrl.Log.WithName("controllers").WithName("Node"),
+		scheme:         mgr.GetScheme(),
+		dryRun:         dryRun,
+	}
 
-// NodeReconciler reconciles a Node object
-type NodeReconciler struct {
-	client.Client
-	Recorder       record.EventRecorder
-	CloudInstances cloudprovider.Instances
-	Log            logr.Logger
-	Scheme         *runtime.Scheme
-	DryRun         bool
+	return r.setupWithManager(mgr)
 }
 
 // Recursively check the list of nodes for any nodes that need to be removed from the cluster
-func (r *NodeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
-	logger := r.Log.WithValues("node", req.NamespacedName).V(1)
+func (r *nodeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
+	logger := r.log.WithValues("node", req.NamespacedName).V(1)
 
 	node := &corev1.Node{}
-	err := r.Client.Get(ctx, req.NamespacedName, node)
+	err := r.client.Get(ctx, req.NamespacedName, node)
 	if err != nil {
 		if apierrors.IsNotFound(err) {
 			// Request object not found, could have been deleted after reconcile request.
@@ -109,28 +127,37 @@ func (r *NodeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 	return ctrl.Result{}, nil
 }
 
-// SetupWithManager sets up the controller with the Manager.
-func (r *NodeReconciler) SetupWithManager(mgr ctrl.Manager) error {
+// setupWithManager sets up the controller with the Manager.
+func (r *nodeReconciler) setupWithManager(mgr ctrl.Manager) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&corev1.Node{}).
 		Complete(r)
 }
 
-func (r *NodeReconciler) nodeStatus(ctx context.Context, node *corev1.Node) (providerNodeStatus, error) {
-	providerID := node.Spec.ProviderID
-	if providerID == "" {
-		return providerNodeStatusUnknown, errProviderIDEmpty
+func (r *nodeReconciler) getProviderID(node *corev1.Node) (string, error) {
+	id := node.Spec.ProviderID
+	if id != "" {
+		return id, nil
+	}
+
+	return generateProviderID(r.cloud, node)
+}
+
+func (r *nodeReconciler) nodeStatus(ctx context.Context, node *corev1.Node) (providerNodeStatus, error) {
+	providerID, err := r.getProviderID(node)
+	if err != nil {
+		return providerNodeStatusUnknown, err
 	}
 
-	nodeExists, err := r.CloudInstances.InstanceExistsByProviderID(ctx, providerID)
+	nodeExists, err := r.cloudInstances.InstanceExistsByProviderID(ctx, providerID)
 	if err != nil && !isAWSNotFoundErr(err) { // This is a hack to work around aws bug
 		return providerNodeStatusUnknown, err
 	}
 	if !nodeExists {
 		return providerNodeStatusNotFound, nil
 	}
 
-	nodeShutdown, err := r.CloudInstances.InstanceShutdownByProviderID(ctx, providerID)
+	nodeShutdown, err := r.cloudInstances.InstanceShutdownByProviderID(ctx, providerID)
 	if err != nil && !isAWSNotFoundErr(err) { // This is a hack to work around aws bug
 		return providerNodeStatusUnknown, err
 	}
@@ -140,7 +167,7 @@ func (r *NodeReconciler) nodeStatus(ctx context.Context, node *corev1.Node) (pro
 	return providerNodeStatusUnknown, nil
 }
 
-func (r *NodeReconciler) reconcileNode(ctx context.Context, node *corev1.Node, logger logr.Logger) (ctrl.Result, error) {
+func (r *nodeReconciler) reconcileNode(ctx context.Context, node *corev1.Node, logger logr.Logger) (ctrl.Result, error) {
 	nodeStatus, err := r.nodeStatus(ctx, node)
 	if err != nil {
 		logger.Error(err, "Unable to get node status")
@@ -163,11 +190,11 @@ func (r *NodeReconciler) reconcileNode(ctx context.Context, node *corev1.Node, l
 	ref := newNodeRef(node)
 	msg := fmt.Sprintf("Deleting node %s because node status is %s", node.Name, nodeStatus.String())
 	logger.Info(msg)
-	r.Recorder.Event(ref, corev1.EventTypeNormal, deleteNodeEvent, msg)
+	r.recorder.Event(ref, corev1.EventTypeNormal, deleteNodeEvent, msg)
 
 	// Nuke 'em, captain.
-	if !r.DryRun {
-		err := r.Client.Delete(ctx, node)
+	if !r.dryRun {
+		err := r.client.Delete(ctx, node)
 		if err != nil {
 			logger.Error(err, "Unable to delete node")
 		}

controllers/provider_id_extractor.go

@@ -0,0 +1,133 @@
+/*
+Copyright 2021.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package controllers
+
+import (
+	"errors"
+	"fmt"
+	"strconv"
+	"strings"
+
+	"k8s.io/legacy-cloud-providers/azure"
+
+	corev1 "k8s.io/api/core/v1"
+	cloudprovider "k8s.io/cloud-provider"
+)
+
+var providerIDBuilders = map[string]func(cloud cloudprovider.Interface, node *corev1.Node) (string, error){
+	"azure": azureProviderIDBuilder,
+	"aws":   awsProviderIDBuilder,
+}
+
+var (
+	// ErrProviderNotSupported is returned when an attempt is made
+	// to generate a provider id for an unsupported provider.
+	ErrProviderNotSupported = errors.New("provider not supported")
+
+	// ErrInvalidVMName is returned when an invalid VM name is found.
+	ErrInvalidVMName = errors.New("vm id is invalid")
+)
+
+func generateProviderID(cloud cloudprovider.Interface, node *corev1.Node) (string, error) {
+	f, ok := providerIDBuilders[cloud.ProviderName()]
+	if !ok {
+		return "", ErrProviderNotSupported
+	}
+	return f(cloud, node)
+}
+
+// awsProviderIDBuilder takes a node name and returns a provider id.
+// For example:
+//   k8s-controllers-i-042988b09f6a493cc
+// becomes:
+//   aws:///i-042988b09f6a493cc
+// error will always be ErrInvalidVMName.
+func awsProviderIDBuilder(_ cloudprovider.Interface, node *corev1.Node) (string, error) {
+	parts := strings.Split(node.Name, "-")
+	if len(parts) != 4 || parts[2] != "i" {
+		return "", ErrInvalidVMName
+	}
+	return fmt.Sprintf("aws:///%s-%s", parts[2], parts[3]), nil
+}
+
+// azureProviderIDBuilder attempts to build a Azure ProviderID.
+func azureProviderIDBuilder(cloud cloudprovider.Interface, node *corev1.Node) (string, error) {
+	name := node.Name
+	azCloud, ok := cloud.(*azure.Cloud)
+	if !ok {
+		return "", errors.New("cloud provider is not azure")
+	}
+
+	scaleset, err := extractAzureScaleSet(name)
+	if err != nil {
+		return "", err
+	}
+
+	vmID, err := extractAzureVMID(name)
+	if err != nil {
+		return "", err
+	}
+
+	if azCloud.Config.VMType == "vmss" {
+		return fmt.Sprintf(
+			"azure:///subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/virtualMachineScaleSets/%s/virtualMachines/%s",
+			azCloud.SubscriptionID,
+			azCloud.ResourceGroup,
+			scaleset,
+			vmID,
+		), nil
+	}
+	return fmt.Sprintf(
+		"azure:///subscriptions/%s/resourceGroups/%s/virtualMachines/%s",
+		azCloud.SubscriptionID,
+		azCloud.ResourceGroup,
+		vmID,
+	), nil
+}
+
+// extractAzureVMID takes a machine name and returns the ID. For example:
+//   aks-agentpool-34751183-vmss001001
+// becomes:
+//    1001
+// error will always be ErrInvalidVMName.
+func extractAzureVMID(name string) (string, error) {
+	// Azure names are padded with leading zeros so there should always be
+	// at least six alphanumeric characters.
+	if len(name) < 6 {
+		return "", ErrInvalidVMName
+	}
+	id := name[len(name)-6:]
+	i, err := strconv.ParseInt(id, 36, 64)
+	if err != nil {
+		return "", ErrInvalidVMName
+	}
+	return strings.ToUpper(strconv.FormatInt(i, 36)), nil
+}
+
+// extractAzureScaleSet takes a machine name and returns the scale set.
+// For example:
+//   aks-agentpool-34751183-vmss001001
+// becomes:
+//   aks-agentpool-34751183-vmss
+// error will always be ErrInvalidVMName.
+func extractAzureScaleSet(name string) (string, error) {
+	if len(name) <= 6 {
+		return "", ErrInvalidVMName
+	}
+	name = name[:len(name)-6]
+	return name, nil
+}