Tidy github workflows (#461)

* Rename ci-nym-vpn-cli to ci-nym-vpn-core

* Rename wf to match filename

* Rename ci-cargo-deny to ci-nym-vpn-core-cargo-deny

* Update comment

* Rename generate-build-info to generate-build-info-desktop

* Delete unused release notes file nym-vpn-core.md

* Rename release notes files for core

.github/workflows/ci-cargo-deny.yml → .github/workflows/ci-nym-vpn-core-cargo-deny.yml

@@ -1,4 +1,4 @@
-name: ci-cargo-deny
+name: ci-nym-vpn-core-cargo-deny
 on:
   pull_request:
     paths:
@@ -12,7 +12,7 @@ jobs:
           sudo apt-get update && sudo apt-get install -y curl gcc git
       - uses: dtolnay/rust-toolchain@stable
       # The cargo-deny action uses docker which we currently can't run on
-      # ubuntu-22.04, so we have to build manually for now
+      # ubuntu-22.04-arc, so we have to build manually for now
       - run: cargo install --locked cargo-deny
       - run: |
           cd nym-vpn-core

.github/workflows/ci-nym-vpn-cli.yml → .github/workflows/ci-nym-vpn-core.yml

@@ -1,4 +1,4 @@
-name: ci-nym-vpn-cli
+name: ci-nym-vpn-core
 
 on:
   # push:

.github/workflows/generate-build-info.yml → .github/workflows/generate-build-info-desktop.yml

@@ -1,4 +1,4 @@
-name: generate-build-info
+name: generate-build-info-desktop
 on:
   workflow_dispatch:
   workflow_call:
@@ -14,7 +14,7 @@ on:
         type: string
 
 jobs:
-  generate-build-info:
+  generate-build-info-desktop:
     runs-on: ubuntu-22.04-arc
     steps:
       - name: Checkout repo

.github/workflows/publish-nym-vpn-core.yml

@@ -163,7 +163,7 @@ jobs:
         run: |
           (echo "SUBJECT=nym-vpn-core-v${{ steps.package-version-lib.outputs.metadata }} nightly prerelease build";
            echo 'PRERELEASE=--prerelease';
-           echo 'NOTES_FILE=release-notes/release-notes-nightly.md') >> $GITHUB_ENV
+           echo 'NOTES_FILE=release-notes/release-notes-core-nightly.md') >> $GITHUB_ENV
           gh release delete nightly --yes || true
           git push origin :nightly || true
 
@@ -172,7 +172,7 @@ jobs:
         run: |
           (echo "SUBJECT=$TAG_NAME"
            echo 'PRERELEASE='
-           echo 'NOTES_FILE=release-notes/release-notes.md') >> $GITHUB_ENV
+           echo 'NOTES_FILE=release-notes/release-notes-core.md') >> $GITHUB_ENV
 
       - name: Build info
         run: |

.github/workflows/publish-nym-vpn-desktop.yml

@@ -28,8 +28,8 @@ jobs:
     uses: ./.github/workflows/build-nym-vpn-desktop-windows.yml
     secrets: inherit
 
-  generate-build-info:
-    uses: ./.github/workflows/generate-build-info.yml
+  generate-build-info-desktop:
+    uses: ./.github/workflows/generate-build-info-core.yml
     needs: build-nym-vpn-desktop-linux
     with:
       build-profile: release