Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task handling in wireguard mode #2184

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

octol
Copy link
Contributor

@octol octol commented Feb 14, 2025

  • Remove the unused reconnect logic in the bandwidth controller and go back to a single unified TaskManager.
  • Dispose the shared mixnet client after signal shutdown but before dropping the task manager

This should fix all those unexpected drop (VPN-2849) errors that happen during disconnect.

IMPORTANT: we need to solidly confirm that the reconnect logic is as unused as I think it is. And test it properly on Android


This change is Reviewable

@octol octol marked this pull request as ready for review February 14, 2025 11:11
@octol octol force-pushed the jon/remove-mixnet-reconnect branch from 548884c to cb4d02c Compare February 14, 2025 11:13
@octol octol requested review from pronebird and neacsu February 14, 2025 11:14
@octol octol force-pushed the jon/remove-mixnet-reconnect branch from cb4d02c to c5ced2e Compare February 17, 2025 16:10
Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be tested.

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @octol)

@octol octol force-pushed the jon/remove-mixnet-reconnect branch from b9eeb7d to 6222f1f Compare February 18, 2025 22:34
@zaneschepke zaneschepke self-requested a review February 19, 2025 10:20
@octol octol merged commit a9f2d89 into develop Feb 19, 2025
12 of 13 checks passed
@octol octol deleted the jon/remove-mixnet-reconnect branch February 19, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants