-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile winfw on CI #2314
Compile winfw on CI #2314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 57 of 136 files at r1, all commit messages.
Reviewable status: 57 of 136 files reviewed, 1 unresolved discussion (waiting on @octol)
build-windows-modules.ps1
line 15 at r1 (raw file):
switch ($CopyToBuildDir) { $true {
Not very familiar with PowerShell. There's no if
else
statement there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 56 of 136 files reviewed, 1 unresolved discussion (waiting on @neacsu and @octol)
build-windows-modules.ps1
line 15 at r1 (raw file):
Previously, neacsu (Bogdan-Ștefan Neacşu) wrote…
Not very familiar with PowerShell. There's no
if
else
statement there?
This is my first powershell script :) Let me have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 55 of 136 files reviewed, 1 unresolved discussion
build-windows-modules.ps1
line 15 at r1 (raw file):
Previously, pronebird (Andrej Mihajlov) wrote…
This is my first powershell script :) Let me have a look.
Fixed
third-party/windows
tonym-vpn-windows
This change is