Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile winfw on CI #2314

Merged
merged 12 commits into from
Feb 28, 2025
Merged

Compile winfw on CI #2314

merged 12 commits into from
Feb 28, 2025

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Feb 28, 2025

  • Pin rustc to 1.84.1 across all CI flows
  • Add script to build winfw and restore the relevant CI flows
  • Move third-party/windows to nym-vpn-windows

This change is Reviewable

@pronebird pronebird requested a review from octol February 28, 2025 12:32
@pronebird pronebird requested a review from neacsu February 28, 2025 16:20
Copy link
Collaborator

@neacsu neacsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 57 of 136 files at r1, all commit messages.
Reviewable status: 57 of 136 files reviewed, 1 unresolved discussion (waiting on @octol)


build-windows-modules.ps1 line 15 at r1 (raw file):

switch ($CopyToBuildDir) {
    $true {

Not very familiar with PowerShell. There's no if else statement there?

Copy link
Contributor Author

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 56 of 136 files reviewed, 1 unresolved discussion (waiting on @neacsu and @octol)


build-windows-modules.ps1 line 15 at r1 (raw file):

Previously, neacsu (Bogdan-Ștefan Neacşu) wrote…

Not very familiar with PowerShell. There's no if else statement there?

This is my first powershell script :) Let me have a look.

@pronebird pronebird merged commit 2c70f8f into develop Feb 28, 2025
14 of 15 checks passed
@pronebird pronebird deleted the am/winfw-ci branch February 28, 2025 16:50
Copy link
Contributor Author

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 55 of 136 files reviewed, 1 unresolved discussion


build-windows-modules.ps1 line 15 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

This is my first powershell script :) Let me have a look.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants