Apple account controller ios#5655
Draft
tommyv1987 wants to merge 8 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace NymVpnAccountStorage prepareRegisteredAccount, prefetch, and summary fetch with short-lived NymAccountController sessions. Fresh login fetches ticketbooks behind ProcessingAccountView (120s); BG refresh uses 25s. Skip AC when NE tunnel is active; teardown on background and connect start. Cherry-picks background-fetch UI (arc policy, IAP, onboarding, CI gates).
tommyv1987
force-pushed
the
feature/apple-account-controller-rust
branch
from
9438328 to
7eb3414
Compare
tommyv1987
force-pushed
the
feature/apple-account-controller-ios
branch
from
c8ad928 to
8ed5755
Compare
tommyv1987
changed the base branch from
feature/apple-account-controller-rust
to
develop
- `MixnetConfig` passes `enableNotifications` into `GatewayIndependence` and threads server-family reminder settings from `AppSettings`. - Adds missing `serverFamilyRemindersEnabled` storage and `setGatewayIndependenceNotifications` through tunnel messaging and macOS gRPC. - Replaces missing Rust `VpnError.AccountStoreBusy` with Swift-only `VPNErrorReason.accountStoreBusy` for the tunnel-active guard. - Splits iOS account-controller session code into `CredentialsManager+iOSAccountController.swift` so SwiftLint stays under the type body error limit. - Excludes `**/build/**` from local SwiftLint so SourcePackages are not scanned.
- iOS uses short-lived NymAccountController sessions for account summary, zk-nym prefetch, and post-register prep instead of storage-only prefetch hacks. - Onboarding account prep treats inactive subscription as prepared so new accounts reach plan purchase without an account controller error alert. - Login and create-account processing screens orchestrate summary sync and prefetch with shared gates and carousel UX. - Account registration retries on store-busy conflicts and shuts down controllers when connecting or entering background. - Passphrase sign-in routes through session coordinator and performAccountRegistration on iOS.
- iOS uses short-lived NymAccountController sessions for account summary, zk-nym prefetch, and post-register prep. - Web portal purchases force a mandatory account refresh and poll until active, fixing stale no active subscription after returning from nym.com checkout. - Privy login and create-account imports register when the VPN API token is missing and block auth completion until a usable token exists. - Credential import during checkout overlay completes pending Privy handoff even when the drawer is hidden. - Onboarding account prep treats inactive subscription as prepared so new accounts reach plan purchase without a controller error alert. - Login and create-account processing screens orchestrate summary sync and prefetch with shared gates and carousel UX. - Account and devices refreshes subscription status on open and when a payment deeplink is received. - AccountSummaryRefreshPolicy and onboarding session policy unit tests cover refresh and import token gates.
- Big amendments to onboarding flow and seamless connectivity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Checklist:
Screenshots (optional, if UI related)
This change is