Draft
Conversation
Add format_token, format_tokens_as_ocaml_array, and linearization_token_strings functions that convert linearization expressions to compact Polish notation token arrays (via to_polish()) formatted as OCaml array literals. Exports fp_linearization_token_strings and fq_linearization_token_strings as OCaml FFI functions, used by gen_scalars_tokens to generate scalars_tokens.ml — a token-based alternative to the tree-walking scalars.ml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
IfFeature(f, e1, e2) was encoded as two SkipIfNot tokens with the same flag. This meant both branches had the same skip polarity, requiring interpreters to track pairing state to know which SkipIfNot was the "first" (true branch) vs "second" (false branch). Now the false branch uses SkipIf (skip if enabled), giving each branch the correct polarity: - SkipIfNot(f, N) [e1] — skip true branch when disabled - SkipIf(f, M) [e2] — skip false branch when enabled Exactly one branch evaluates per IfFeature, producing one value on the stack. Interpreters become stateless: each token independently decides skip-or-advance based on the feature flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ensures Bigint256.of_hex_string compatibility without per-callsite workarounds in OCaml consumers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.