Repository navigation
Fail fast in E2E tests when the CLI exits before an expected prompt - #783
Merged
Merged
Conversation
`waitForText` from the CLI testing library never settles when the text does not appear. When `zk deploy` failed early (for example, "Failed to find the fee payer's account on chain"), the E2E helper waited forever for the "Are you sure you want to send (yes/no)?" prompt. With the Playwright per-test timeout at 180 minutes and the nightly job timeout at 185 minutes, every nightly job was killed by the job timeout instead of reporting a test failure. This has happened on all 8 nightly jobs every night since 2026-05-06. - Add `waitForPrompt` to `executeInteractiveCommand`: it races the prompt against the CLI process exit (polled) and a 10 minute upper bound, and fails with the captured stdout/stderr. - Lower the Playwright per-test timeout from 180 to 60 minutes so that a stuck test fails and reports before the job is killed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
`zk deploy` reported "Failed to find the fee payer's account on chain" for both a missing account and a failed GraphQL request. Print the transport or GraphQL error when the lookup itself failed, so CI logs can tell the two apart. Also add the changelog entry for the E2E fail-fast change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
===========================================
- Coverage 100.00% 99.93% -0.07%
===========================================
Files 11 11
Lines 1492 1494 +2
Branches 304 305 +1
===========================================
+ Hits 1492 1493 +1
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Trivo25
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Nightly E2E tests workflow has hit the 185-minute job timeout on all 8 jobs every night since 2026-05-06. Over the last 30 days that is ~37,700 runner-minutes, or ~152,000 billable-equivalent minutes once the macOS (10x) and Windows (2x) multipliers are applied. No nightly run has passed in the 412 runs GitHub still has on record.
Root cause of the hang (verified from the job logs):
should deploy zkApp of generated projecttest,zk deploystops early withFailed to find the fee payer's account on chainand exits.executeInteractiveCommandintests/utils/cli-utils.tswaits for theAre you sure you want to send (yes/no)?prompt viawaitForTextfrom@shimkiv/cli-testing-library. That promise never settles when the text does not appear, so the test sits until the Playwright timeout.playwright.config.tssets the per-test timeout to 180 minutes, and the job timeout is 185 minutes, so the job is killed before Playwright reports anything.What
executeInteractiveCommandnow waits for a prompt viawaitForPrompt, which races the prompt against the CLI process exit (polled every 250 ms) and a 10 minute upper bound. On failure it throws with the captured stdout/stderr.zk deploynow prints the underlying transport/GraphQL error when the fee payer lookup request itself fails, so a failed request can be told apart from a missing account.Verification
npx tsc --noEmit, prettier and eslint pass;src/lib/deploy.test.jspasses (67 tests).should deploy zkApp of generated projectE2E test passes locally against the mocked endpoints with o1js 2.15.0 (the version installed by the project template today), including the interactive prompt path.Open question
The
Failed to find the fee payer's account on chainfailure in CI is not reproduced locally with the same o1js version, so its cause is still unknown. It started the day after o1js 2.15.0 was published (2026-05-05), but that correlation is not confirmed. With this PR the nightly will fail in ~15 minutes per job instead of 185 and the new diagnostic line will show the actual lookup error. Until the lookup failure is fixed, consider disabling the nightly schedule or trimming the matrix (node 18 is end of life; the mocked macOS and Windows jobs are the bulk of the cost).🤖 Generated with Claude Code