Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of non-essential, experimental, sample and test data gems #649

Draft
wants to merge 18 commits into
base: development
Choose a base branch
from

Conversation

AMZN-alexpete
Copy link
Contributor

@AMZN-alexpete AMZN-alexpete commented Jan 13, 2024

What does this PR do?

Copies non-essential, sample, experimental, test data and asset heavy gems from the o3de repo to o3de-extras to improve build times, asset processing times, bandwidth, infrastructure costs, local disk usage and SDK installer size.

The gems will be made available through the canonical.o3de.org remote repository where they can easily be downloaded by users and then removed from the main o3de repository.

This PR copies the following gems or content:

  • Atom/ColorGrading from Gems/Atom/Feature/Common/Tools/ColorGrading
  • Atom/Hermanubis from Gems/AtomLyIntegration/CommonFeatures/Assets/Objects/Hermanubis
  • Atom/LightingPresets from Gems/Atom/Feature/Common/Assets/LightingPresets
  • Atom/ReferenceMaterials from Gems/AtomContent/ReferenceMaterials
  • Atom/Sponza from Gems/AtomContent/Sponza
  • Atom/TechnicalArt from Gems/AtomLyIntegration/TechnicalArt
  • Atom/TestData from Gems/AtomContent/TestData
  • AtomTressFX
  • CustomAssetExample
  • DevTextures
  • GameStateSamples
  • LyShineExamples
  • Meshlets
  • Metastream
  • MotionMatching
  • PrimitiveAssets
  • SceneLoggingExample
  • SliceFavorites

This decreases the size of the engine Gems folder from 2.03GB to 380MB and removes several of the largest assets that take the longest time for the Asset Processor to compile.

⚠️ Additional PRs will be needed in the o3de repository to correct automated tests, remove unnecessary large files and make sure everything works as intended etc.

None of these gems are used in the DefaultProject template or MinimalProject template

TODO

  • Leave lightingpresets/highcontrast/goegap_* in Gems/Atom/Feature/Common (used by default level)
  • Move Gems/Atom/Feature/Common/Assets/ColorGrading/TestData to Atom/TestData gem
  • [ ]

How was this PR tested?

⚠️ still need to make repo.json updates in order to test remote downloading
⚠️ still need to make appropriate changes to AutomatedTesting and AtomSampleViewer to ensure this doesn't break any tests or dependencies

From Atom/Feature/Common/Tools/ColorGrading

Signed-off-by: Alex Peterson <[email protected]>
From Atom/Feature/Common/Assets/LightingPresets

Signed-off-by: Alex Peterson <[email protected]>
From Gems/AtomLyIntegration/CommonFeatures/Assets/Objects/Hermanubis

Signed-off-by: Alex Peterson <[email protected]>
Copy link
Contributor

@moudgils moudgils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably broke a lot of ASV samples. Haveyou tesed it?

@AMZN-alexpete
Copy link
Contributor Author

This probably broke a lot of ASV samples. Haveyou tesed it?

I have not tested the change with AutomatedTesting or ASV yet, but this PR does not remove these Gems from o3de, I will first make the changes necessary to not break tests before removing anything from the o3de r epo.

@byrcolin byrcolin requested review from a team April 16, 2024 17:30
@byrcolin byrcolin added sig/build Categorizes an issue or PR as relevant to SIG Build. sig/core Categorizes an issue or PR as relevant to SIG Core labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/build Categorizes an issue or PR as relevant to SIG Build. sig/core Categorizes an issue or PR as relevant to SIG Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants