Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded openxr dependency to 1.1.41. #823

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

galibzon
Copy link
Contributor

@galibzon galibzon commented Feb 3, 2025

What does this PR do?

Upgrades openxr dependency to 1.1.41, and simplifies developer steps to build O3DE apps on Meta Quest devices.

This update makes it straightforward to build O3DE applications for Meta Quest devices, because the developer is not required anymore to download and decompress the Oculus OpenXR Mobile SDK.

To understand this change, let's review a little bit of history: When making O3DE apps for Meta Quest devices, the developer was instructed to manually download and decompress the
Oculus OpenXR Mobile SDK into a particular directory of the OpenXRVk Gem.
Those instructions worked well until SDK v62.

Starting SDK v63+ (It's currently at v72)
Meta stopped distributing pre-compiled OpenXR Loader libraries, and now applications are simply required to get the OpenXR Loader directly from github: https://github.com/KhronosGroup/OpenXR-SDK

In particular, this PR picks version 1.1.41 because that's the version used by v72 of Oculus OpenXR Mobile SDK.
In other words, with this change, OpenXR is now supported in its purest form, because there are no custom steps for a particular vendor.

How was this PR tested?

  1. Tested OpenXRTest project with XR_Office level on both Windows (Using Quest Link with a Quest3 device) and natively on Android running on a Quest3.
  2. Tested our private Quest3 project on Windows (Using Quest Link with a Quest3 device) and natively on Android running on a Quest3.

REMARK 1: This PR is contingent on https://github.com/o3de/3p-package-source/pull/270.

REMARK 2: Not validated on Linux (and not sure if OpenXR support has ever been tested on Linux).

This update makes it straightforward to build O3DE
applications for Meta Quest devices, because the developer
is not required anymore to download and decompress the `Oculus OpenXR Mobile SDK`.

To understand this change, let's review a little bit of history:
When making O3DE apps for Meta Quest devices, the developer
was instructed to manually download and decompress the
 `Oculus OpenXR Mobile SDK` into a particular directory of the `OpenXRVk` Gem.
Those instructions worked well until SDK v62.

Starting SDK v63+ (It's currently at v72)
Meta stopped distributing pre-compiled OpenXR Loader libraries, and now applications are simply
required to get the OpenXR Loader directly from github:
https://github.com/KhronosGroup/OpenXR-SDK

In particular, this PR picks version 1.1.41 because that's the version used
by `v72` of `Oculus OpenXR Mobile SDK`.
In other words, with this change, OpenXR is now supported in its purest form,
because there are no custom steps for a particular vendor.

Signed-off-by: galibzon <[email protected]>
Copy link
Contributor

@byrcolin byrcolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@byrcolin byrcolin added sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio. sig/platform Categorizes an issue or PR as relevant to SIG Platform. labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio. sig/platform Categorizes an issue or PR as relevant to SIG Platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants