Move crypto-policies actors to common to execute it also in el9toel10 workflow

[The-Mule]

It turns out that cryptopoliciescheck is not only useful for el8toel9 upgrade path but also for any upgrade path where crypto-policies is present.

RHEL-77169

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please @oamg/developers to notify leapp developers of the review request
• /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

• /packit test to re-run manually the default tests
• /packit retest-failed to re-run failed tests manually
• /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

• /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
• /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

[The-Mule]

@Jakuje, you are the original author of this actor, can you take a quick look if moving it to common (from el8toel9) is done right? Compared to the original version I only made two changes:

1. I made it 'no-op' for 7to8 upgrade
2. Reference to Red Hat documentation is only used during 8to9 upgrade.

[Jakuje]

You need also the

https://github.com/oamg/leapp-repository/blob/main/repos/system_upgrade/el8toel9/actors/scancryptopolicies/actor.py

which produces the CryptoPolicyInfo message you need here.

[The-Mule]

Thanks Jakub, there's also model that needs to be moved. However, neither cryptopoliciescheck nor scancryptopolicies are applicable to el7toel8 update path. Hence I would have to disable the tests somehow there and maybe the cleaner way would actually be moving both cryptopoliciescheck and scrancryptopolicies (and all other related stuff) to el8toel9. Once RHEL-7 will go out of support we can move it common, it would make more sense at that point.

[The-Mule]

I just did that - instead of moving to common, I duplicated both cryptopoliciescheck and scancryptopolicies actors and their corresponding model to el9toel10, the only difference between their el8toel9 and el9toel10 version is the removal of documentation reference from el9toel10 version.

If there is some nice way how to have them in common while disabling them and their tests for el7toel8 upgrade path I'll be happy to move them there.

[Jakuje]

I think copying code is never way to go as it will make the maintainer to fix the bugs in two places, which is very error prone. I would rather have them in common + disable test with something like

import distro

@pytest.mark.skipif(int(distro.major_version()) < 8, reason="Requires EL8 or newer")

[Jakuje]

@The-Mule I took over the PR and went back to the using the "common" repo instead of having just another copy of the same actors and tests. We talked about the approach with @pirat89 today so this should be close enough to get merged soon (I hope :) )

[The-Mule]

Perfect, thanks @Jakuje, I greatly appreciate that!