Skip to content

Add new Leapp actor to preinstall gnome-settings-daemon-server-defaults on "Server with GUI" el9 -> el10 upgrades#1506

Open
tpopela wants to merge 1 commit into
oamg:mainfrom
tpopela:gnomesettingsdaemoncheck
Open

Add new Leapp actor to preinstall gnome-settings-daemon-server-defaults on "Server with GUI" el9 -> el10 upgrades#1506
tpopela wants to merge 1 commit into
oamg:mainfrom
tpopela:gnomesettingsdaemoncheck

Conversation

@tpopela
Copy link
Copy Markdown

@tpopela tpopela commented Mar 9, 2026

Prior to RHEL 10 we didn't have a way to enforce some of the desktop environment changes to be only Server specific (such as disabling the power button handling or disabling automatic suspendand) hence we had to enable everything for everyone. In RHEL 10 we've added a new subpackage of gnome-settings-daemon, the gnome-settings-daemon-server-defaults which is only preinstalled on "Server with GUI" product and on nothing else. But this only works for clean installations as the comps groups are not synced when doing the upgrades with Leapp. To fix that we've created this Leapp actor which will detect if the graphical-server-environment comps group was installed and only in the case it will preinstall the server-defaults subpackage.

Developed by Claude Code.

Jira: RHEL-148697

…ts on "Server with GUI" el9 -> el10 upgrades

Prior to RHEL 10 we didn't have a way to enforce some of the desktop environment
changes to be only Server specific (such as disabling the power button handling
or disabling automatic suspendand) hence we had to enable everything for
everyone. In RHEL 10 we've added a new subpackage of gnome-settings-daemon, the
gnome-settings-daemon-server-defaults which is only preinstalled on
"Server with GUI" product and on nothing else. But this only works for
clean installations as the comps groups are not synced when doing the
upgrades with Leapp. To fix that we've created this Leapp actor which
will detect if the graphical-server-environment comps group was
installed and only in the case it will preinstall the server-defaults
subpackage.

Developed by Claude Code.

Resolves: RHEL-148697
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the leapp-repository contribution and development guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 self-assigned this Mar 10, 2026
@pirat89 pirat89 self-requested a review March 10, 2026 09:01
@pirat89 pirat89 added the bug Something isn't working label Mar 10, 2026
@pirat89 pirat89 added this to the 8.10/9.9 milestone Mar 10, 2026
Copy link
Copy Markdown
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed over slack. Current implementation seems to be working, however we do not allow interraction with the system during checksphase. Also I think that it makes sense to scan information about installed comps, so I decided to implement that part. However, current design (mainly common dnf-related libraries) seems to be a little bit not-ideal for that purposes. So I plan to do the groundwork in #1507 - once the PR is merged, we can updated this one.

@pirat89 pirat89 mentioned this pull request Mar 10, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants