Skip to content

Add inhibitor for incorrect /var/run symlink configuration#1546

Open
prjagtap-rh wants to merge 1 commit into
oamg:mainfrom
prjagtap-rh:check-var-run-symlink
Open

Add inhibitor for incorrect /var/run symlink configuration#1546
prjagtap-rh wants to merge 1 commit into
oamg:mainfrom
prjagtap-rh:check-var-run-symlink

Conversation

@prjagtap-rh
Copy link
Copy Markdown
Contributor

If /var/run is not correctly configured as a symbolic link to /run, the in-place upgrade can lead to boot failures, service startup failures, or login issues. A new ChecksPhase actor detects this unsupported configuration and inhibits the upgrade.

JIRA: RHEL-76846

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the leapp-repository contribution and development guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 added this to the 8.10/9.9 milestone Jun 3, 2026
@prjagtap-rh prjagtap-rh force-pushed the check-var-run-symlink branch from ba4c2d4 to 80f1e8e Compare June 3, 2026 12:28
@prjagtap-rh prjagtap-rh requested a review from pirat89 June 3, 2026 12:31
@prjagtap-rh prjagtap-rh force-pushed the check-var-run-symlink branch from 80f1e8e to f7a6375 Compare June 5, 2026 07:00
In modern Linux systems that use systemd, /run is a tmpfs filesystem
managed by systemd and /var/run must be a symbolic link pointing to
../run for compatibility. Inhibit the upgrade if /var/run is not
configured as expected, as this can cause boot failures, service
startup failures, or login issues.

Extended the FileInfo model with a real_path field and add /var/run to
the scansourcefiles tracked files list. The ChecksPhase actor consumes
the TrackedFilesInfoSource message to detect this unsupported
configuration and inhibits the upgrade.

JIRA: RHEL-76846
@prjagtap-rh prjagtap-rh force-pushed the check-var-run-symlink branch from f7a6375 to 8ddb8fc Compare June 5, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants