Parameter aliases conflict with system query options #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
reviewed
Jan 29, 2025
ralfhandl
approved these changes
Jan 30, 2025
mikepizzo
requested changes
Feb 5, 2025
lib/csdl2openapi.js
Outdated
| if ( | ||
| implicitAliases && | ||
| csdl.$Version !== "2.0" && | ||
| SYSTEM_QUERY_OPTIONS.includes(p.$Name) |
There was a problem hiding this comment.
This should be a case-insensitive comparison
ralfhandl
approved these changes
Feb 6, 2025
mikepizzo
approved these changes
Feb 12, 2025
HeikoTheissen
added a commit
to HeikoTheissen/openapi
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.