Schemas for create and update exist even in read-only services #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAPI description generated by
V4-CSDL-to-OpenAPI.xslfor this read-only OData V4 service correctly contains only GET pathsand not POST, PATCH and DELETE paths.
But it still contains unused schemas
which irritatingly show up in the Swagger UI.
This has been solved as part of #291, see the Swagger UI. But that pull request changes the whole approach of the XSLT transformation and is not yet ready for merging. The purpose of this pull request is to avoid the unused schemas in the OpenAPI (and Swagger) description without relying on #291.
(
csdl2openapi.jsdoes not generate such superfluous schemas.)