Memorydump update #16
Conversation
|
Why have you closed it? |
It is not clear whether it is necessary or not. If needed. I will create a request again. cbMemoryView conflicts with cbSystemView. BlueHazzard create cbMemoryView plugin only for test target. |
|
There is a reopen button.... |
My plugin is not part of the official codeblocks installation. I just mentioned in the forum, because it is related... |
Adding descriptions of how plugins work
How is it calculated 128 number in m_LineText
|
Added comments about change in plugin |
src/src/examinememorydlg.cpp
Outdated
| @@ -38,17 +37,24 @@ ExamineMemoryDlg::ExamineMemoryDlg(wxWindow* parent) : | |||
| return; | |||
| m_pText = XRCCTRL(*this, "txtDump", wxTextCtrl); | |||
|
|
|||
| wxFont font(8, wxFONTFAMILY_MODERN, wxFONTSTYLE_NORMAL, wxFONTWEIGHT_NORMAL); | |||
| wxFont font(12, wxFONTFAMILY_MODERN, wxFONTSTYLE_NORMAL, wxFONTWEIGHT_NORMAL); | |||
There was a problem hiding this comment.
Why have you increased the size?
| @@ -7,26 +7,26 @@ | |||
| <object class="wxBoxSizer"> | |||
| <object class="sizeritem"> | |||
| <object class="wxStaticText" name="ID_STATICTEXT1"> | |||
| <label>Address:</label> | |||
There was a problem hiding this comment.
Please don't abbreviate things. The abbreviation of "address" is more common to be "addr" also.
| <border>2</border> | ||
| </object> | ||
| <object class="sizeritem"> | ||
| <object class="wxComboBox" name="colSelect"> |
There was a problem hiding this comment.
Please use wxChoice they work better on wxGTK.
| } | ||
| } | ||
|
|
||
| #define HEX_OFFSET(a) (a*3) | ||
| #define CHAR_OFFSET(a) (16*3 + 3 + a) | ||
| #define HEX_OFFSET(a) (a*3) | ||
| //#define CHAR_OFFSET(a) (16*3 + 3 + a) |
There was a problem hiding this comment.
If you don't use this any more you better remove this.
| protected: | ||
| void OnGo(wxCommandEvent& event); | ||
|
|
||
| private: | ||
| wxTextCtrl* m_pText; | ||
| size_t m_ByteCounter; | ||
| wxChar m_LineText[67]; // 16*3 "7F " + 3 " " + 16 "." | ||
| unsigned m_ColumnsCtrl; |
There was a problem hiding this comment.
Naming something ctrl means it is the actual variable to the control. Please use just m_Columns or m_NumColumns.
src/src/examinememorydlg.cpp
Outdated
| m_pText->AppendText(m_LineText[i]); | ||
|
|
||
| // for (int i = 0; i < (m_PartLength + m_ColumnsCtrl); ++i) | ||
| // m_LineText[i] = _T(' '); |
There was a problem hiding this comment.
The identation of this block is a mess. Please fix.
| m_pText->Clear(); | ||
| m_LastRowStartingAddress = 0; | ||
| m_ByteCounter = 0; | ||
| for (int i = 0; i < 67; ++i) | ||
|
|
||
| m_PartLength = (m_ColumnsCtrl * 2) + m_ColumnsCtrl; |
There was a problem hiding this comment.
What does this mean? Why do you just multiply by 3?
|
It's funny, but I can't edit commits. This action is not possible. |
|
Why do you want to edit commits? Just push new commits to your branch and this PR would be updated. |
MemoryDump update. I left all the new functions, I checked the patch, everything works.