Turn disjoint_union_over into a proper ODK component
#3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the `disjoint_union_over` component to give it a `.owl` extension. Other components written in OWL functional syntax uses the `.owl` extension, no reason to single that component out. The ontology IRI inside that component is itself using a `.owl` extension, so let's align the filename with the IRI.
We import the disjoint_over_union component into the -edit file, so that the axioms it contains are visible from editors when they work on the ontology (e.g. from Protégé).
Declare 'components/disjoint_union_over.owl' as a ODK-managed component. Do not explicitly merge it in the OWLSRC preprocessing step (it will still be merged at this point, because it is imported in the -edit file).
The declared ontology IRI of the disjoint_union_over component must match the IRI of the import declaration, otherwise Protégé will not load the component properly.
anitacaron
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
src/ontology/components/disjoint_union_over.ofntosrc/ontology/components/disjoint_union_over.owl, both for consistency with other components in OWL functional syntax that use a.owlextension and for alignment with the ontology IRI within that file;-editfile, so that its axioms are explicitly visible to editors (e.g. from Protégé) instead of only appearing in theuberon.owlrelease product;uberon.owl.closes #3180