enhance: add enqueue key with delay #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
g-linville,
ibuildthecloud,
iwilltry42 and
StrongMonkey
If a user uses resp.RetryAfter in a handler, the object's key is enqueued without the trigger designation. That means, that all triggers for the object will be invoked regardless of whether the object changes when it goes through the handlers. This is not the desired behavior. If the object doesn't change, then the triggers should not be invoked. This change adds an EnqueueKeyWithDelay function that achieves this desired behavior. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
enqueue-key-with-delay
branch
from
b062d9e to
6f19204
Compare
StrongMonkey
approved these changes
Feb 27, 2025
cjellick
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user uses resp.RetryAfter in a handler, the object's key is enqueued
without the trigger designation. That means, that all triggers for the object
will be invoked regardless of whether the object changes when it goes through
the handlers. This is not the desired behavior. If the object doesn't change,
then the triggers should not be invoked.
This change adds an EnqueueKeyWithDelay function that achieves this desired
behavior.