fix: avoid excessive form resets (#1852)

obot-platform · Feb 25, 2025 · 3b5cb44 · 3b5cb44
1 parent aa8a0e3
commit 3b5cb44
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/ui/admin/app/components/agent/AgentForm.tsx b/ui/admin/app/components/agent/AgentForm.tsx
@@ -58,10 +58,6 @@ export function AgentForm({
 		},
 	});
 
-	useEffect(() => {
-		if (agent) form.reset(agent);
-	}, [agent, form]);
-
 	useEffect(() => {
 		return form.watch((values) => {
 			if (!onChange) return;

diff --git a/ui/admin/app/components/agent/AgentIntroForm.tsx b/ui/admin/app/components/agent/AgentIntroForm.tsx
@@ -34,19 +34,11 @@ export function AgentIntroForm({
 		resolver: zodResolver(formSchema),
 		mode: "onChange",
 		defaultValues: {
-			introductionMessage: "",
-			starterMessages: [],
+			introductionMessage: agent.introductionMessage ?? "",
+			starterMessages: agent.starterMessages ?? [],
 		},
 	});
 
-	useEffect(() => {
-		if (agent)
-			form.reset({
-				introductionMessage: agent.introductionMessage ?? "",
-				starterMessages: agent.starterMessages ?? [],
-			});
-	}, [agent, form]);
-
 	useEffect(() => {
 		return form.watch((values) => {
 			if (!onChange) return;