chore: change the config setup via environment variables in the helm chart #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpebcak
requested changes
Mar 7, 2025
chart/Chart.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| apiVersion: v2 | |||
| name: obot | |||
| description: A Helm chart for Obot | |||
| version: 0.1.0 | |||
| version: 0.1.1 | |||
There was a problem hiding this comment.
no need to update this, the version is set dynamically when we do a release of obot.
thedadams
approved these changes
Mar 7, 2025
|
I'll merge this later after I update the terraform and stuff to account for the new values |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By switching the naming in the values.yaml to the env var names, we can drop quite a bit of templating and have the generated secret and the existingSecret behave the same.
Slack Thread: https://acorn-io.slack.com/archives/C03FU91U4SX/p1740643210636069
issue: #1966