feat: add top level obot page to admin ui #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- additionally ensure project IDs are converted properly when forwarding to the UI Signed-off-by: Ryan Hopper-Lowe <[email protected]>
ryanhopperlowe
commented
Mar 7, 2025
| @@ -49,7 +50,7 @@ func convertThread(thread v1.Thread) types.Thread { | |||
| LastRunID: thread.Status.LastRunName, | |||
| CurrentRunID: thread.Status.CurrentRunName, | |||
| State: state, | |||
| ProjectID: thread.Spec.ParentThreadName, | |||
| ProjectID: strings.Replace(thread.Spec.ParentThreadName, system.ThreadPrefix, system.ProjectPrefix, 1), | |||
There was a problem hiding this comment.
Since thread.Spec.ParentThreadName is always a project I figured it made sense to convert the projectID value when sending to the UI
| AssistantID: thread.Spec.AgentName, | ||
| Editor: thread.IsEditor(), | ||
| UserID: thread.Spec.UserID, |
There was a problem hiding this comment.
Needed this to display a Created By field in the admin UI
ryanhopperlowe
requested review from
ivyjeong13,
StrongMonkey,
thedadams,
cjellick,
drpebcak,
njhale,
iwilltry42 and
g-linville
and removed request for
StrongMonkey
ryanhopperlowe
commented
Mar 8, 2025
| @@ -5,6 +5,8 @@ type Project struct { | |||
| ProjectManifest | |||
| AssistantID string `json:"assistantID,omitempty"` | |||
| Editor bool `json:"editor"` | |||
| ParentID string `json:"parentID,omitempty"` | |||
There was a problem hiding this comment.
Let me know if parentID is too ambiguous
ivyjeong13
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1958
Spawned from,Agent,Created ByObotfilter for the/chat-threadspage