feat: configure k8s affinity, tolerations, and resources #4709
Conversation
Signed-off-by: Grant Linville <[email protected]>
| // Retry loop to handle conflicts | ||
| var settings v1.K8sSettings | ||
| for i := 0; i < 5; i++ { |
There was a problem hiding this comment.
I'm not 100% sure why I was experiencing 409s here to begin with, but the loop fixed it. If there is a better fix or something obviously wrong that was causing the 409s, please let me know.
| func newK8sSettingsGetter(client storage.Client) K8sSettingsGetter { | ||
| return &k8sSettingsGetter{ | ||
| client: client, | ||
| cacheTTL: 30 * time.Second, // Cache for 30 seconds |
There was a problem hiding this comment.
Not sure that a cache is really necessary, but Claude added one, so I figured we might as well keep it.
| type K8sSettingsGetter interface { | ||
| GetK8sSettings(ctx context.Context) (*v1.K8sSettingsSpec, error) | ||
| } |
There was a problem hiding this comment.
I'm really not sure that this interface is necessary. It seems the main reason it is here is for locking and caching purposes. Pretty sure caching is not needed, but I don't think locking is needed either. In the place where this Getter is used, I think we can just use an obot storage client directly instead...let me know if you have any thoughts on this.
1 participant
for #4677