chore: Config v2 route handling refactor #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
added a commit
that referenced
this pull request
Feb 10, 2025
* refactor route parsing * Ensure routes returned are not nil * refactor config v2 read routes * typo
jsirianni
added a commit
that referenced
this pull request
Feb 10, 2025
* Generate component ID * test id change * lint: package comment * feat(resource): Connectors for configuration v2 (#141) * add connectors * support delete * move readRolloutOptions() * WIP: We need component ID to be generated before apply * generate connector id * Remove test file * feat: Configuration V2 with routing (#143) * support delete * WIP: We need component ID to be generated before apply * Remove test file * rough working concept * test some advanced routing * remove route id, bindplane can generate it * input validation * resolve validation func * linter * fix issue with telemetry type and route id not persisting * feat: Configuration V2 Processors (#144) * support delete * WIP: We need component ID to be generated before apply * test some advanced routing * remove route id, bindplane can generate it * input validation * resolve validation func * fix issue with telemetry type and route id not persisting * WIP: We need component ID to be generated before apply * implement create * implement read * sync tests * chore: Test against v1.74.0 - current (#145) * lets see which versions work :) * tighten up versions * add version notice * doc processor groups on config v2 (#146) * feat: Config v2 connectors (#147) * add connector to config v2 schema * fix tests from bad rebase upstream * support connectors in the configuration * chore: Config v2 route handling refactor (#148) * refactor route parsing * Ensure routes returned are not nil * refactor config v2 read routes * typo * fix: Config v2 routes should use TypeSet to avoid ordering requirements (#149) * Fix an issue where the config v2 read func was not comparing route_id correctly * refactor RoutesToState further * use TypeSet for routes in order to avoid ordering constraint * ci * Route (#150) * unify route schema * implement route_id and enable connector support * add license * linter fixes * doc * fix bad rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please check that the PR fulfills these requirements