more treemap#1732
Draft
Fil wants to merge 5 commits intombostock/treemapfrom
Draft
Conversation
assuming that channels x1, x2, y1, y2 are specified. An alternative would be to create a "textbox" mark which would combine a rect and a text; it would probably allow more nice things, like anchoring the text to the left of the box…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several elements that might help with treemaps.
clipping to a rect (#1109)
There are two issues here:
node:branch and node:size helpers
node:branch retrieves the id of the top-level branch and color the rects; the original example was using the internal d3 hierarchy object, which shows a leaky abstraction; should this leak be closed?
node:size shows the value.
a default text and title
default text is the node:name, default title is node:name + node:size
I'm happy that it generally works, but it opens a few questions about how to make this as generic as possible.
faceting
treemap areas are comparable across facets
todo: