propagate title and href by default #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
reviewed
Jan 16, 2022
Fil
reviewed
Jan 18, 2022
src/transforms/group.js
Outdated
Comment on lines
275
to
277
| const groups = sort(rollup(I, V => V.length, i => X[i]), second); | ||
| const top = groups.slice(-5).reverse(); | ||
| if (top.length < groups.length) top.push(["Other", sum(groups.slice(0, -5), second)]); |
There was a problem hiding this comment.
Suggested change
| const groups = sort(rollup(I, V => V.length, i => X[i]), second); | |
| const top = groups.slice(-5).reverse(); | |
| if (top.length < groups.length) top.push(["Other", sum(groups.slice(0, -5), second)]); | |
| const N = 5; | |
| const groups = sort(rollup(I, V => V.length, i => X[i]), second); | |
| const top = groups.slice(-N).reverse(); | |
| if (top.length < groups.length) top.push([groups.length === N + 1 ? groups[N][0] : "Other", sum(groups.slice(0, -N), second)]); |
There was a problem hiding this comment.
(if there are exactly 6 groups we can use the 6th's name.)
There was a problem hiding this comment.
Changed to show the number of other categories, as well as the number of constituent elements.
|
Note for the future: the locale (#384) should also apply to "Other". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617.