Always open in new tab setting #497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davish
requested changes
Oct 2, 2023
Collaborator
davish
left a comment
davish
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Just a few suggestions before merging.
src/ui/settings.ts
Outdated
| }; | ||
| timeFormat24h: boolean; | ||
| clickToCreateEventFromMonthView: boolean; | ||
| alwaysOpenInNewTab: boolean; |
Collaborator
There was a problem hiding this comment.
Suggested change
| alwaysOpenInNewTab: boolean; | |
| alwaysOpenInNewTab?: boolean; |
Both of these settings should be optional, since they won't be present in existing Full Calendar installations. Following the type errors should lead you to add some more edge cases to fill in the defaults as they should in those cases.
src/ui/actions.ts
Outdated
| { workspace, vault }: { workspace: Workspace; vault: Vault }, | ||
| id: string | ||
| id: string, | ||
| settings?: FullCalendarSettings |
Collaborator
There was a problem hiding this comment.
Suggested change
| settings?: FullCalendarSettings | |
| openInNewTab: boolean |
Could you pass the setting in as its own parameters rather than passing in the whole settings object? I'd prefer it to be explicit what settings openFileForEvent is using from its type signature.
Contributor
Author
There was a problem hiding this comment.
Sure, just updated the branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer the calendar tab not to close when opening an event (but open a new tab instead). This way its easier to compare and switch notes of multiple events. So maybe we could add this setting to always have clicks to open in a new tab?
Without setting (current, many clicks needed)
With setting (this PR, less clicks needed)
Invert Ctrl-setting for opening modal vs file
Also (second commit in this PR), I tend to want to open the note more than I want to open the edit modal. So I added a setting for inverting the modifier key as well (ctrl for opening modal instead of ctrl for opening the file - notes are central for me):