-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add plugin: First Line is Title #7429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1][2]:Using Do NOT open a new PR for re-validation. |
|
Changes requested by bot have been made, ready for additional review by human. |
|
if (typeof window.localStorage !== 'undefined' && window.localStorage.getItem('language')) {, "minAppVersion": "1.7.0", const styleEl = document.createElement('style'); callback: async () => {, callback: async () => { callback: async () => {, callback: async () => { if (!content.startsWith('---')) {, if (!content.startsWith('---')) { for (const line of yamlLines) { const frontmatter = parseYaml(yaml);Optional feedback: "watch": "^0.13.0" if (!this.settings.enableCommandPalette) {, if (!this.settings.commandPaletteVisibility.renameCurrentFile) { const tagRegex = /#([a-zA-Z][\w-_/]*)/g; contentForRateLimit = await this.plugin.app.vault.read(file); Please note that this is an initial review, a more thorough review will occur when the above changes have been made. The bot will mark this PR as "changes made" when it has detected that you have made all the required changes. The bot checks about every 4 hours. |
|
I see that the bot added
|
|
Removed, was previously a comment from the eslint bot |
|
Installing the dependencies in your plugin failed with the following error: |
|
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2] [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30][31][32][33][34][35][36][37][38][39][40][41][42][43][44][45][46][47][48][49][50][51][52][53][54][55][56][57][58][59][60][61][62][63][64][65][66][67][68][69][70][71][72][73][74][75][76][77][78][79][80][81][82][83][84] [1][2][3][4][5][6][7] [1][2][3] [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22] [1][2][3] [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28] [1][2][3][4][5][6][7][8][9] [1][2] [1] [1] [1][2][3] [1][2][3][4][5][6] [1][2][3][4][5][6] [1][2] [1] [1][2] [1] [1] [1] [1] Optional[1][2] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1][2] [1] [1] [1][2] [1] [1] [1][2][3][4][5][6] [1] [1] [1] [1][2] [1][2][3][4][5] [1] [1][2] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1][2] [1] [1] [1][2] [1] [1] [1] [1][2] [1] [1] [1] [1] [1] [1] Do NOT open a new PR for re-validation. |
1 similar comment
|
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2] [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30][31][32][33][34][35][36][37][38][39][40][41][42][43][44][45][46][47][48][49][50][51][52][53][54][55][56][57][58][59][60][61][62][63][64][65][66][67][68][69][70][71][72][73][74][75][76][77][78][79][80][81][82][83][84] [1][2][3][4][5][6][7] [1][2][3] [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22] [1][2][3] [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28] [1][2][3][4][5][6][7][8][9] [1][2] [1] [1] [1][2][3] [1][2][3][4][5][6] [1][2][3][4][5][6] [1][2] [1] [1][2] [1] [1] [1] [1] Optional[1][2] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1][2] [1] [1] [1][2] [1] [1] [1][2][3][4][5][6] [1] [1] [1] [1][2] [1][2][3][4][5] [1] [1][2] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1] [1][2] [1] [1] [1][2] [1] [1] [1] [1][2] [1] [1] [1] [1] [1] [1] Do NOT open a new PR for re-validation. |
|
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3] [1][2][3][4][5][6] [1] [1][2][3][4][5] Optional[1] [1] [1] [1] [1] [1] [1][2] Do NOT open a new PR for re-validation. |
|
Changes requested by bot have been made, ready for for additional review by human. |
|
this._originalDebugEnable = window.DEBUG?.enable;, saveCommand.checkCallback = (checking: boolean) => { private registeredEvents: EventRef[] = [];, this.registeredEvents.forEach((ref) =>, this.registeredEvents.push(event); state.currentLocale = moment.locale(); if (this.settings.core.enableRibbon) {, condition: this.settings.core.ribbonVisibility.renameCurrentFile,, condition: this.settings.core.ribbonVisibility.renameAllNotes,, condition: this.settings.core.ribbonVisibility.toggleAutomaticRenaming, setupNotificationSuppression(): void { if (file.stat.ctime < this.plugin.pluginLoadTime - 1000) { const view = leaf.view as MarkdownView;, const view = leaf.view as MarkdownView; Optional feedback: setupCommandPaletteIcons(): void { I'm still working through your plugin, I would like to apologize for this taking so long, and say thank you for your patience. I believe we've fixed the bot, so hopefully we can go back and forth quicker and get this in for you. |
This is in place because Obsidian does not remember ribbon icon configuration if a plugin is lazy loaded, such as with Lazy Plugin Loader — hidden icons reappear in the ribbon when a plugin is loaded lazily. This issue seems to affect all plugins, not just this one. I would also like to keep this:
I've not found a clean solution to this. It seems that Obsidian is at fault here, not my plugin. I've seen at least one other plugin also plagued by this problem: https://github.com/alangrainger/obsidian-frontmatter-modified-date?tab=readme-ov-file#merging-changes-popup I inquired about this problem in #plugin-dev on Discord. (There, I replied to manumov saying that his suggestion worked but I later discovered that it actually didn't.) This notification is not only completely useless and very annoying but is actually misleading — files are modified from within Obsidian, not externally. Without this option, the first line alias feature is utterly unusable. No overreach: the option to suppress the notification is OFF by default.
This is only in place for the Quick Switcher++ plugin, which can show command icons in its command mode. The icons never appear in the vanilla Command palette. Resolved all other issues. |
That should be fixed on that plugin's end then. It doesn't change the Obsidian development guidelines.
It can be difficult to properly solve this problem, but it is possible. I recommend asking in that channel again for more help. Suppressing these notifications is not the answer. Note to self: here's the link to mnaoumov's answer
Is that the recommended way to add icons to the Quick Switcher++ plugin commands? If so can you link to documentation around that? They should provide you with a better API than that. |
A search through the docs only seems to bring up the Ribbon actions page, which doesn't prohibit ribbon toggles in plugin settings.
I just posted a new message in #plugin-dev.
Turns out my plugin's commands already had icons set via addCommand(). Removed redundant JavaScript injection code. |
|
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2] [1][2] Optional[1] Do NOT open a new PR for re-validation. |
|
Thanks, created a PR to add that guideline to the docs, obsidianmd/obsidian-developer-docs#216 |
|
Is 'no ribbon toggles' a requirement or suggestion? |
|
It's a requirement for new plugins, a suggestion for existing plugins. |
|
Accidentally deleted then restored greetclammy/obsidian-releases. Reopening. |
Hello!I found the following issues in your plugin submission Errors: ❌ Unable to find a release with the tag This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/greetclammy/first-line-is-title
Release Checklist
main.jsmanifest.jsonstyles.css(optional)v)idin mymanifest.jsonmatches theidin thecommunity-plugins.jsonfile.I have given proper attribution to these other projects in my
README.md.