Canvases - Part Deux (Loading/Saving + Frontend API) #11832
Draft
+1,625
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allos creating additional views that act like a MAIN_VIEW instead of AUX_VIEW.
This adds a new obs_canvas object that acts as a shareable (reference-counted) owner of views, mixes, and (optionally) scenes. This is a step towards faciliatating multi-canvas and multi-output features in OBS Studio. It solves a number of complications that exist with the manual approach of using views, such as audio mixing, source active-state tracking, and scenes not havinga reliable way of identifying the actual available canvas size.
Since scenes now can have non-unique names by being part of different canvases, use UUIDs instead.
Signals when a video reset has completed. This is mainly useful when canvases or views are used, whose mixes will have been freed or recreated during the reset.
In addition to the global reset, canvas video can be reset independently. This signal can be used to detect if the canvas video was reset, whether by another API user or through a global reset.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
This contains the previous PR (#11823) and hence is a draft.
Adds saving and loading for frontend-owned canvases as well as a frontend API to create/remove/enumerate them.
Motivation and Context
In order to persist additional canvases and their scenes/sources in a way that is reasonably straightforward for API users we want the frontend to own/manage additional canvases that it may interface with.
In the future I'd also like to make transitions and the main canvas part of this abstraction.
How Has This Been Tested?
This was tested with this fork of the vertical canvas plugin that makes use of the new APIs: https://github.com/dsaedtler/obs-vertical-canvas
Types of changes
Checklist: