Issue a warning when old is used on a non-modified variable
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
warnings
branch
2 times, most recently
from
10dda3d to
1b186eb
Compare
pascutto
reviewed
Apr 12, 2022
Comment on lines
+643
to
+650
| | Tvar vs -> | ||
| if | ||
| not | ||
| (List.exists | ||
| (function { t_node = Tvar vs' } -> vs = vs' | _ -> false) | ||
| wr) | ||
| then Some vs.vs_name.id_str | ||
| else None |
There was a problem hiding this comment.
I don't think that would be enough. For instance, you would reject the following:
val f : 'a array -> unit
(*@ f x
modifies x
ensures let y = x in old y.(0) = 0You need a more subtle data flow analysis to know which variables are actually modified when you write modifies x.
Co-authored-by: Clément Pascutto <[email protected]>
You mean in two different PRs? |
Co-authored-by: Clément Pascutto <[email protected]>
Co-authored-by: Clément Pascutto <[email protected]>
Co-authored-by: Clément Pascutto <[email protected]>
pascutto
changed the title
old is used on a non-modified variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39.