Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ortac load a subset of plugins #195

Closed
wants to merge 1 commit into from

Conversation

n-osborne
Copy link
Collaborator

@n-osborne n-osborne commented Jan 15, 2024

This PR is based on #194, please consider only the last commit.

This PR proposes to load the installed subset of plugins.
This will be useful for testing the dune plugin, and for generating dune file using the dune plugin when testing the other ones.

The adopted convention is to separate the plugins names with a comma.

@n-osborne n-osborne force-pushed the ortac_plugins_option branch from d5f7bb4 to 95cf8e8 Compare January 15, 2024 10:26
@n-osborne n-osborne changed the title This PR is based on #194, please consider only the last commit. Make ortac load a subset of plugins Jan 15, 2024
@n-osborne n-osborne requested a review from shym January 15, 2024 10:35
Copy link
Contributor

@shym shym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice indeed, well done!
I would just have been curious to see it put into use in some test :-) But, as you say, I’m not sure we have a valid use case until the dune plugin is available.

This feature will be usefull to test the dune plugin (ocaml-gospel#190) in CI.
@n-osborne n-osborne force-pushed the ortac_plugins_option branch from 95cf8e8 to 59b61d7 Compare January 16, 2024 09:38
@n-osborne
Copy link
Collaborator Author

Thanks.
It turns out that (at the moment at least) the dune plugin doesn't generate rules that need two loaded plugins.
I propose to keep this PR unmerged until we need its modifications (if or when the monolith plugin is revived, it may certainly be useful).

@n-osborne n-osborne marked this pull request as draft February 7, 2024 09:56
@n-osborne n-osborne closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants