Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCaml 5.3 when using certain C++ compilers #56

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

kit-ty-kate
Copy link
Contributor

@kit-ty-kate kit-ty-kate commented Sep 5, 2024

@kit-ty-kate kit-ty-kate marked this pull request as draft October 10, 2024 17:21
@kit-ty-kate
Copy link
Contributor Author

was fixed in dune 3.16.1

@kit-ty-kate kit-ty-kate closed this Dec 6, 2024
@kit-ty-kate
Copy link
Contributor Author

it was in fact not fixed by dune 3.16.1 as the fix is only enabled when using (lang dune 3.0) or later...

@kit-ty-kate kit-ty-kate reopened this Jan 8, 2025
@kit-ty-kate kit-ty-kate force-pushed the ocaml-5.3-macos branch 2 times, most recently from c559d3b to c67d740 Compare January 9, 2025 00:06
@kit-ty-kate kit-ty-kate marked this pull request as ready for review January 9, 2025 00:07
@kit-ty-kate
Copy link
Contributor Author

Tested locally on macOS sucessfully (fails before, succeeds after pinning this branch). Doing a release.

@kit-ty-kate kit-ty-kate merged commit 224a5b5 into ocaml-opam:master Jan 9, 2025
15 of 16 checks passed
@kit-ty-kate kit-ty-kate deleted the ocaml-5.3-macos branch January 9, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.3 regression] Failure when using the C API in C++ code
1 participant