Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Ast_pattern.fail. #563

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

ceastlund
Copy link
Collaborator

Without this function it was hard to write new pattern matchers using of_func.

@ceastlund ceastlund marked this pull request as ready for review February 11, 2025 20:41
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Just a comment on the functions documentation but besides that it's good to go!

@ceastlund ceastlund merged commit 3884b40 into ocaml-ppx:main Feb 12, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants