remove residual code from PR #320, which is no longer useful#578
Open
lsylvestre wants to merge 2 commits intoocaml-sf:masterfrom
Open
remove residual code from PR #320, which is no longer useful#578lsylvestre wants to merge 2 commits intoocaml-sf:masterfrom
lsylvestre wants to merge 2 commits intoocaml-sf:masterfrom
Conversation
Collaborator
|
Thanks @lsylvestre ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #481 allows external pre-compiled code to be used in the grading environment, effectively replacing
the existing mechanism for test code reuse (PR #320).
This existing mechanism is no longer supported (it is now ignored by grader/grading.ml),
but residual code continues to run. In particular, an exception is raised when file depend.txt
is present in the exercise folder and specifies invalid file paths.
This new PR removes residual code from PR #320
This closes issue #366