Skip to content

Community page #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2021
Merged

Community page #1296

merged 5 commits into from
Mar 31, 2021

Conversation

Aditi-1400
Copy link
Contributor

Modified the styles of community Page

@avsm
Copy link
Member

avsm commented Mar 23, 2021

Thanks for this contribution @Aditi-1400! It would be useful to have a little more motivation behind the PR -- what are you trying to fix with this (was there a broken layout before?) and link to the URLs that are affected. If you can include a screenshot of the before/after from your fixes, that would make the improvement more obvious too. Once that's done, I can push the resulting change to the staging.ocaml.org site for more testing. Thanks!

@patricoferris
Copy link
Contributor

Thanks @Aditi-1400 -- just for future reference, as Anil points out, it's always good to provide a little context. When managing lots of issues and PRs it can be hard to remember who is working on what. In this instance a link back to the original issue in the description of the PR would suffice. All of the conversation is over on #1254 :))

@avsm avsm added the pushed-to-staging pushed to staging.ocaml.org label Mar 31, 2021
@avsm
Copy link
Member

avsm commented Mar 31, 2021

Confirmed on staging that this looks better on mobile now, so merging. Thanks for the contribution, @Aditi-1400!

image

@avsm avsm merged commit 2e22187 into ocaml:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pushed-to-staging pushed to staging.ocaml.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants