Skip to content

Added discourse icon to Ocaml Around the Web #1318 #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Added discourse icon to Ocaml Around the Web #1318 #1375

merged 2 commits into from
Apr 6, 2021

Conversation

gurleennsidhuu
Copy link
Contributor

Issue Description:

Adds discourse icon to the section "Ocaml Around the Web" in community page.

Fixes: #1318

Changes Made:

The discourse icon (linked to https://discuss.ocaml.org/ ) has been added to the 'Ocaml Around the Web' section.

#Before:
before
#After:
after

@pitag-ha
Copy link
Member

pitag-ha commented Apr 2, 2021

LGTM, thanks!

The layout still doesn't look great at the moment (same as before your contribution), but there is another issue that someone else can work on to fix that. So this looks good to me as is.

@avsm
Copy link
Member

avsm commented Apr 6, 2021

Looks good to me. Thanks @gurleennsidhuu for the contribution, and @pitag-ha for the review.

@avsm avsm merged commit 0df1d18 into ocaml:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add discourse to OCaml Around the World
3 participants