Make sure zone_id is available when deleting normal records

[troykelly]

A possible fix for #118

[ross]

Any idea why the record doesn't have a zone_id that seems fairly odd.

Otherwise I'd lean towards a smaller PR that focuses on fixing the error you ran into. The additional error handling seems reasonable, but I'd prefer to see the "fix" PR focused on the specific problem and it's solution. That way if there are unintended side effects they'll be more clearly traceable.

The other cleanup/changes may make sense as well, but in PRs dedicated to that topic.

[troykelly]

Any idea why the record doesn't have a zone_id that seems fairly odd.

No idea - this has been working for some time, and I can't see any recent version changes that coincide with the failure - it just stopped working 18 hours ago. Could it be that Cloudflare have changed something they return, so it's now missing the required data?

I haven't had time to look at the broader code - and I just needed to get a fix in place, so, apologies - but I don't even know where the values are sourced from. I saw that it was sourcing zone_id for pagerules https://github.com/octodns/octodns-cloudflare/blob/51c34b65b3405adeca395c0bba8b1b97af672f9d/octodns_cloudflare/__init__.py#L1155C17-L1155C24 - and thought it could be a quick fix.

[ross]

OK. I'll pull things up tomorrow and see if I can reproduce it or otherwise figure out what might be going on.