-
Notifications
You must be signed in to change notification settings - Fork 79
chore(deps): update jest monorepo and ts-jest to v27 (major) #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b6b8bf1
to
b845249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires update to ts-jest
yeah bump to |
ts-jest 27.0.0 has now been released |
The "express middleware no mount path no next" test is currently failing for me in
I'm not sure what the problem here is. @wolfy1339 any idea what it could be? |
I had the same problem in my PR #552 |
I've read something in the release notes that the running order might change with v27, so that is probably what we see here. I think we have to figure this out for good now :D |
Hi @wolfy1339. I'm sorry but these days I have a limited amount of time to check into this. Just to get context and catch up with Octokit status, how critical is this upgrade? Is it blocking ESModules migration? |
Native ESM was introduced in this Jest version, so I think it is a critical piece to the migration |
Likewise I've had a bit of an explosion in work (which is why I've not been able to help out as much lately 😞). In saying that... This is because you're calling Ideally you should add that to all of the tests in the file to ensure the right type of timers (real or fake) are used for each test. |
No worries @G-Rath, I hope everything gets stable soon. 💪🏽 In my case I lost my job due to COVID situation and now I'm focusing in learning React, building my profile, etc. As soon as I solve my professional situacion I will get back. I'm willing to catch up with all the things you have built lately.
EDIT: NICE CATCH @G-Rath |
Great work y’all, thank you! |
🎉 This PR is included in version 9.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates:
^26.6.2
->^27.0.0
^26.2.2
->^27.0.0
Release Notes
facebook/jest
v27.0.1
Compare Source
Fixes
[jest-environment-jsdom]
Bump version of JSDOM to avoid deprecatedrequest
package (#11442)Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by WhiteSource Renovate. View repository job log here.