[IMP] Frontdesk: updating to new standards #12917
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @slinkous - this is ready for a peer review. Thanks! |
slinkous
approved these changes
Apr 18, 2025
slinkous
approved these changes
Apr 18, 2025
larm-odoo
force-pushed
the
18.0-frontdesk-updating-to-new-standards-LARM
branch
from
f2408ee to
4c4df21
Compare
|
Hi @samueljlieber - this is ready for a tech review! |
samueljlieber
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Hi @larm-odoo, requesting changes as there are a number of remaining updates needed. Please make sure to update each emoji with the respective icon :) Thank you!
larm-odoo
force-pushed
the
18.0-frontdesk-updating-to-new-standards-LARM
branch
from
4c4df21 to
0576735
Compare
|
Oh my gosh, I looked at those so many times and all I thought was "funny, that pencil is yellow" and my brain didn't tell me to change it! All the icons are updated - I am so sorry! The only one I didn't was the "camera with a "+" icon" since that was something we came up with when I originally did the docs - unless there is a better way of describing the image boxes. Alright- ready for another look @samueljlieber! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to new standards (app names are bold, etc). Updated the warning when accessing a kiosk, as you are automatically signed out regardless of how you access the database. Also changed dummy data to be more obviously fake (555-555-5555, etc)