[IMP] ecommerce: update product/attribute page #12922
Closed
+54
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lman-odoo
force-pushed
the
17.0-ecommerce-products-page-lman
branch
from
270d2ef to
5538837
Compare
auva-odoo
requested changes
Apr 18, 2025
There was a problem hiding this comment.
Thank you @lman-odoo for your work! I realized while reviewing it that the task's specs weren't clear and accurate regarding the Ecommerce description field (see my comment on lines 162-165). This is on me, I'm sorry!
I added a few other comments/suggestions; let me know if you have any questions! Also, don't forget the 100th character limit (line 170 and lines 235-244 in the products.rst file) 😉
content/applications/sales/sales/products_prices/products/variants.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/products/variants.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/products/variants.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/products/variants/color-option-ecommerce.png
Outdated
Show resolved
Hide resolved
lman-odoo
force-pushed
the
17.0-ecommerce-products-page-lman
branch
2 times, most recently
from
e993b15 to
87ad862
Compare
auva-odoo
requested changes
Apr 24, 2025
content/applications/sales/sales/products_prices/products/variants.rst
Outdated
Show resolved
Hide resolved
task-3506952
lman-odoo
force-pushed
the
17.0-ecommerce-products-page-lman
branch
from
87ad862 to
52a2b1a
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 24, 2025
task-3506952 closes #12922 Signed-off-by: Audrey Vandromme (auva) <[email protected]>
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-3506952