[IMP] inventory: security lead times fix #12929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Felicious
changed the title
Felicious
force-pushed
the
18.0-inventory-purchase-security-feku
branch
from
483b539 to
10b27b4
Compare
|
Hi @justinmallette ! This PR is ready for peer review (: |
Felicious
force-pushed
the
18.0-inventory-purchase-security-feku
branch
from
10b27b4 to
564e99c
Compare
|
Oops i found some errors and pushed up another commit 😅 @justinmallette |
justinmallette
approved these changes
Apr 22, 2025
| - Last calendar day to confirm the |RFQ| and convert it to a |PO| | ||
| * - Expected Arrival | ||
| - Arrival date of the products. Calculated by :math:`\text{Order Deadline} + \text{Vendor Lead | ||
| Time}` |
There was a problem hiding this comment.
Suggested change
| Time}` | |
| Time}` |
There was a problem hiding this comment.
The render is removing the space between Lead and Time
| .. example:: | ||
| To tie all the purchase lead times together, consider this: | ||
|
|
||
| - Today: April 21 |
There was a problem hiding this comment.
Suggested change
| - Today: April 21 | |
| - **Order Placed**: April 21 |
There was a problem hiding this comment.
I don't know the terminology like you do, so replace this if it isn't correct. My concern is that seeing "today" in an example won't make sense since it's relative (even if you're defining it here). Would something like Sales Order Confirmed or something like that work?
|
|
||
| Example of the :abbr:`JIT (just-in-time)` forecast window, which is April 21-28. | ||
|
|
||
| When creating an RFQ today: |
There was a problem hiding this comment.
Suggested change
| When creating an RFQ today: | |
| When creating an RFQ on the day the order was placed/the sales order was confirmed: |
|
|
||
| When creating an RFQ today: | ||
|
|
||
| - :guilabel:`Order Deadline`: April 23 (:math:`\text{Today} + 2`) |
There was a problem hiding this comment.
Suggested change
| - :guilabel:`Order Deadline`: April 23 (:math:`\text{Today} + 2`) | |
| - :guilabel:`Order Deadline`: April 23 (:math:`\text{Order Confirmation Date} + 2`) |
| time selected is the entry at the top of the list. | ||
|
|
||
| .. tip:: | ||
| A PO is marked late if the *Expected Arrival* date has passed, and appears in the *Late* box on |
There was a problem hiding this comment.
Suggested change
| A PO is marked late if the *Expected Arrival* date has passed, and appears in the *Late* box on | |
| A |PO| is marked late if the *Expected Arrival* date has passed, and appears in the *Late* box on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the purchase security lead time error flagged by Jeso
Summary of changes
Received help from Jrma & Shke 😊