[FIX] util/pg: Add optional parameter - #476
Draft
sagu-odoo wants to merge 1 commit into
Draft
Conversation
Contributor
|
|
sagu-odoo
force-pushed
the
master-add-optional-execute-sagu
branch
from
July 30, 2026 11:57
2c98e62 to
c7bae91
Compare
Contributor
Author
sagu-odoo
force-pushed
the
master-add-optional-execute-sagu
branch
from
July 30, 2026 12:07
c7bae91 to
24bdfd4
Compare
Pirols
reviewed
Jul 30, 2026
| or (odoo_module is not None and getattr(odoo_module, "current_test", False)) | ||
| ) | ||
|
|
||
| if allow_parallel: |
Contributor
There was a problem hiding this comment.
I don't think you ever need a parameter for this. The _serial is sort of a fallback when we know we can't run in parallel.
EDIT: As discussed in DM it's really anti idiomatic to call parallel_execute while asking it not to run in parallel. On the caller side you can just write a for loop over exploded queries, and it is to be seen that's even better than a single bigger query.
Contributor
There was a problem hiding this comment.
OTOH, tests for this method should then be changed to explicitly call _parallel_execute_threaded as it's the one that is actually tested.
add optional parameter too run parallel execute in serial wise if needed ``allow_parallel`` `AUTO`
sagu-odoo
force-pushed
the
master-add-optional-execute-sagu
branch
from
July 30, 2026 12:10
24bdfd4 to
af2a2bf
Compare
sagu-odoo
marked this pull request as draft
July 30, 2026 12:22
Contributor
|
upgradeci retry with always only base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add optional parameter too run parallel
execute serial wise if needed.