Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When generated in, allOf Ref will not change. #1147

Closed
wants to merge 7 commits into from

Conversation

utherbit
Copy link
Contributor

@utherbit utherbit commented Dec 26, 2023

fixes #1146

bag fix. When generated in, allOf Ref will not change
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67c195f) 72.44% compared to head (46cf643) 72.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   72.44%   72.45%   +0.01%     
==========================================
  Files         187      187              
  Lines       15029    15028       -1     
==========================================
+ Hits        10888    10889       +1     
+ Misses       3607     3606       -1     
+ Partials      534      533       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utherbit utherbit changed the title https://github.com/ogen-go/ogen/issues/1146 bag fix. When generated in, allOf Ref will not change. Dec 26, 2023
@utherbit utherbit changed the title bag fix. When generated in, allOf Ref will not change. fix: When generated in, allOf Ref will not change. Dec 26, 2023
@ernado
Copy link
Member

ernado commented Dec 26, 2023

Hi, please update your commit message according to semantic commits, so commit name linter is green.
Thanks!

@utherbit
Copy link
Contributor Author

Hi, please update your commit message according to semantic commits, so commit name linter is green. Thanks!

Sorry, but how can I check Lint Commit Messages again?

@utherbit utherbit closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in generating code from specification: discriminator unable to map
2 participants