Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): use response ref as key for wrapped type lookup #1183

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

tdakkota
Copy link
Member

Fixes #1182

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (12082ad) 73.78% compared to head (6383038) 73.78%.
Report is 14 commits behind head on main.

Files Patch % Lines
gen/gen_responses.go 75.00% 0 Missing and 1 partial ⚠️
gen/tstorage.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files         188      188           
  Lines       12659    12661    +2     
=======================================
+ Hits         9340     9342    +2     
  Misses       2785     2785           
  Partials      534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado merged commit 2a652ad into ogen-go:main Feb 20, 2024
14 checks passed
@tdakkota tdakkota deleted the fix-1182 branch February 20, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating a single response structure for different methods using headers
2 participants