Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): use named key in QueryParameterObjectField #1208

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

taxio
Copy link
Contributor

@taxio taxio commented Mar 31, 2024

The code generated for uri.QueryParameterObjectField currently lacks field keys, leading to go vet flagging errors as shown below:

$ go vet ./...
# github.com/ogen-go/ogen/internal/integration/test_form
internal/integration/test_form/oas_request_decoders_gen.go:455:46: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_form/oas_request_decoders_gen.go:455:62: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_form/oas_request_decoders_gen.go:477:46: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_form/oas_request_decoders_gen.go:477:62: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_form/oas_request_decoders_gen.go:700:46: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_form/oas_request_decoders_gen.go:700:62: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
# github.com/ogen-go/ogen/internal/integration/test_parameters
internal/integration/test_parameters/oas_parameters_gen.go:674:45: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_parameters/oas_parameters_gen.go:674:60: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_parameters/oas_parameters_gen.go:674:75: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_parameters/oas_parameters_gen.go:705:45: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_parameters/oas_parameters_gen.go:705:60: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields
internal/integration/test_parameters/oas_parameters_gen.go:705:75: github.com/ogen-go/ogen/uri.QueryParameterObjectField struct literal uses unkeyed fields

While the linter settings for this repository do not trigger any errors, the linter in each ogen user's project does inspect the generated code. Therefore, we want to ensure at a minimum that the code passes go vet.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.84%. Comparing base (adbac42) to head (a89c573).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   73.82%   73.84%   +0.01%     
==========================================
  Files         188      188              
  Lines       12693    12693              
==========================================
+ Hits         9371     9373       +2     
+ Misses       2787     2786       -1     
+ Partials      535      534       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota enabled auto-merge March 31, 2024 08:30
@tdakkota tdakkota merged commit a364c18 into ogen-go:main Mar 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants